dongjoon-hyun commented on code in PR #49564: URL: https://github.com/apache/spark/pull/49564#discussion_r1927803620
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala: ########## @@ -249,6 +249,8 @@ class JDBCOptions( .map(_.toBoolean) .getOrElse(SQLConf.get.timestampType == TimestampNTZType) + val hint = parameters.get(JDBC_HINT_STRING).map(_ + " ").getOrElse("") Review Comment: Ur, if you don't mind, can we keep the AS-IS code because there is no harm, @beliefer ? For me, there is no harm to have `hint` here, but please let me know your concerns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org