sarutak commented on code in PR #49191:
URL: https://github.com/apache/spark/pull/49191#discussion_r1922832773
##########
sql/core/src/test/resources/sql-functions/sql-expression-schema.md:
##########
@@ -165,8 +165,8 @@
| org.apache.spark.sql.catalyst.expressions.If | if | SELECT if(1 < 2, 'a',
'b') | struct<(IF((1 < 2), a, b)):string> |
| org.apache.spark.sql.catalyst.expressions.In | in | SELECT 1 in(1, 2, 3) |
struct<(1 IN (1, 2, 3)):boolean> |
| org.apache.spark.sql.catalyst.expressions.InitCap | initcap | SELECT
initcap('sPark sql') | struct<initcap(sPark sql):string> |
-| org.apache.spark.sql.catalyst.expressions.Inline | inline | SELECT
inline(array(struct(1, 'a'), struct(2, 'b'))) | struct<col1:int,col2:string> |
-| org.apache.spark.sql.catalyst.expressions.Inline | inline_outer | SELECT
inline_outer(array(struct(1, 'a'), struct(2, 'b'))) |
struct<col1:int,col2:string> |
+| org.apache.spark.sql.catalyst.expressions.InlineExpressionBuilder | inline |
SELECT inline(array(struct(1, 'a'), struct(2, 'b'))) |
struct<col1:int,col2:string> |
+| org.apache.spark.sql.catalyst.expressions.InlineExpressionBuilder |
inline_outer | SELECT inline_outer(array(struct(1, 'a'), struct(2, 'b'))) |
struct<col1:int,col2:string> |
Review Comment:
@dongjoon-hyun
Hmm, maybe #48503 should have re-generated the golden file right?
If so, I'll remove this irrelevant change manually, and open another PR for
followup.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
