davidm-db commented on code in PR #49445:
URL: https://github.com/apache/spark/pull/49445#discussion_r1920315665
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ColumnResolutionHelper.scala:
##########
@@ -251,19 +251,26 @@ trait ColumnResolutionHelper extends Logging with
DataTypeErrorsBase {
}
}
+ sealed trait LookupVariableMode
+ object LookupVariableMode {
Review Comment:
Also, I would add descriptions here, rather than in the function (can have
them in both places). Whoever looks at the code will be able to navigate to
here to understand the meaning of different enum values, but if someone used
this enum in the future they might forget to add comments to their functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
