grundprinzip commented on code in PR #49529:
URL: https://github.com/apache/spark/pull/49529#discussion_r1919110540
##########
sql/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -228,6 +230,16 @@ message Expression {
DataType struct_type = 1;
repeated Literal elements = 2;
}
+
+ message SpecializedArray {
+ DataType element_type = 1;
Review Comment:
I mean unfortunately, this would rather look like
```
message SpecializedArray {
oneof value_type {
Bools bools = 1;
Ints ints = 2;
// ...
}
message Bools {
repeated bool values = 1;
}
message Ints {
repeated int32 values = 1;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
