milastdbx commented on code in PR #49452:
URL: https://github.com/apache/spark/pull/49452#discussion_r1916424131
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala:
##########
@@ -986,4 +986,39 @@ private[v2] trait V2JDBCTest extends SharedSparkSession
with DockerIntegrationFu
test("scan with filter push-down with date time functions") {
testDatetime(s"$catalogAndNamespace.${caseConvert("datetime")}")
}
+
+ test("SPARK-50792: Format binary data as a binary literal in JDBC.") {
+ val tableName = s"$catalogName.test_binary_literal"
+ withTable(tableName) {
+ // Create a table with binary column
+ val binary = "X'123456'"
+ val lessThanBinary = "X'123455'"
+ val greaterThanBinary = "X'123457'"
+
+ sql(s"CREATE TABLE $tableName (binary_col BINARY)")
+ sql(s"INSERT INTO $tableName VALUES ($binary)")
+
+ def testBinaryLiteral(operator: String, literal: String, expected: Int):
Unit = {
+ val sql = s"SELECT * FROM $tableName WHERE binary_col $operator
$literal"
Review Comment:
lets verify that pushdown is present
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala:
##########
@@ -3097,4 +3097,19 @@ class JDBCV2Suite extends QueryTest with
SharedSparkSession with ExplainSuiteHel
assert(rows.contains(Row(null)))
assert(rows.contains(Row("a a a")))
}
+
+ test("SPARK-50792: Format binary data as a binary literal in JDBC.") {
+ val tableName = "h2.test.binary_literal"
+ withTable(tableName) {
+ // Create a table with binary column
+ val binary = "X'123456'"
+
+ sql(s"CREATE TABLE $tableName (binary_col BINARY)")
+ sql(s"INSERT INTO $tableName VALUES ($binary)")
+
+ val select = s"SELECT * FROM $tableName WHERE binary_col = $binary"
Review Comment:
lets verify that this is actually pushed down - e.g. verify that there is no
FilterExec present in plan
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala:
##########
@@ -986,4 +986,39 @@ private[v2] trait V2JDBCTest extends SharedSparkSession
with DockerIntegrationFu
test("scan with filter push-down with date time functions") {
testDatetime(s"$catalogAndNamespace.${caseConvert("datetime")}")
}
+
+ test("SPARK-50792: Format binary data as a binary literal in JDBC.") {
+ val tableName = s"$catalogName.test_binary_literal"
+ withTable(tableName) {
+ // Create a table with binary column
+ val binary = "X'123456'"
+ val lessThanBinary = "X'123455'"
+ val greaterThanBinary = "X'123457'"
+
+ sql(s"CREATE TABLE $tableName (binary_col BINARY)")
+ sql(s"INSERT INTO $tableName VALUES ($binary)")
+
+ def testBinaryLiteral(operator: String, literal: String, expected: Int):
Unit = {
+ val sql = s"SELECT * FROM $tableName WHERE binary_col $operator
$literal"
Review Comment:
`checkFilterPushed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
