sunxiaoguang commented on code in PR #49452:
URL: https://github.com/apache/spark/pull/49452#discussion_r1916227472
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala:
##########
@@ -986,4 +986,39 @@ private[v2] trait V2JDBCTest extends SharedSparkSession
with DockerIntegrationFu
test("scan with filter push-down with date time functions") {
testDatetime(s"$catalogAndNamespace.${caseConvert("datetime")}")
}
+
+ test("SPARK-50792 Format binary data as a binary literal in JDBC.") {
+ val tableName = s"$catalogName.test_binary_literal"
+ withTable(tableName) {
+ // Create a table with binary column
+ val binary = "X'123456'"
+ val lessThanBinary = "X'123455'"
+ val greaterThanBinary = "X'123457'"
+
+ sql(s"CREATE TABLE $tableName (binary_col BINARY)")
+ sql(s"INSERT INTO $tableName VALUES ($binary)")
+
+ def testBinaryLiteral(operator: String, literal: String, expected: Int):
Unit = {
+ val sql = s"SELECT * FROM $tableName WHERE binary_col $operator
$literal"
+ val rows = spark.sql(sql).collect()
+ assert(rows.length === expected, s"Failed to run $sql")
+ if (expected == 1) {
+ assert(rows(0)(0) === Array(0x12, 0x34, 0x56).map(_.toByte))
+ }
+ }
+
+ testBinaryLiteral("=", binary, 1)
+ testBinaryLiteral(">=", binary, 1)
+ testBinaryLiteral(">=", lessThanBinary, 1)
+ testBinaryLiteral(">", lessThanBinary, 1)
+ testBinaryLiteral("<=", binary, 1)
+ testBinaryLiteral("<=", greaterThanBinary, 1)
+ testBinaryLiteral("<", greaterThanBinary, 1)
+ testBinaryLiteral("<>", greaterThanBinary, 1)
+ testBinaryLiteral("<>", lessThanBinary, 1)
+ testBinaryLiteral("<=>", binary, 1)
+ testBinaryLiteral("<=>", lessThanBinary, 0)
+ testBinaryLiteral("<=>", greaterThanBinary, 0)
Review Comment:
Right, the V2JDBCTest trait mixed in existing integrations and run against
all the dialects. With this test, we figured out that Microsoft SQL Server,
Oracle and PostgreSQL require extra work to support `Binary Literal`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
