davidm-db commented on code in PR #49485: URL: https://github.com/apache/spark/pull/49485#discussion_r1916212729
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParserUtils.scala: ########## @@ -163,6 +163,14 @@ class SqlScriptingLabelContext { bl.multipartIdentifier().getText, el.multipartIdentifier().getText) } + case (Some(bl: BeginLabelContext), _) Review Comment: Let's edit the comment for the `checkLabels` function to match the new behavior, in some of the follow-up PRs. Also, maybe just minor comment that would explain that this case actually relies on the `if` part of the previous one, so someone won't make a silly mistake in future and reorder stuff for whatever reason. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org