davidm-db commented on code in PR #49485:
URL: https://github.com/apache/spark/pull/49485#discussion_r1916213942
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingParserSuite.scala:
##########
@@ -2000,6 +2000,21 @@ class SqlScriptingParserSuite extends SparkFunSuite with
SQLHelper {
assert(tree.collection(4).asInstanceOf[ForStatement].label.get == "lbl")
}
+ test("qualified label name: label cannot be qualified") {
Review Comment:
Look at my other comment, I think it makes sense to add test with END label,
in a follow-up PR as well. This is just in case to guard us if anyone changes
this part of code in an unexpected way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
