HyukjinKwon commented on code in PR #49450:
URL: https://github.com/apache/spark/pull/49450#discussion_r1913984184


##########
python/pyspark/sql/types.py:
##########
@@ -1770,6 +1770,15 @@ def toJson(self, zone_id: str = "UTC") -> str:
         """
         return VariantUtils.to_json(self.value, self.metadata, zone_id)
 
+    @classmethod
+    def parseJson(cls, json_str: str) -> "VariantVal":

Review Comment:
   There are actually some API like `DataType.fromJson` 



##########
python/pyspark/sql/types.py:
##########
@@ -1770,6 +1770,15 @@ def toJson(self, zone_id: str = "UTC") -> str:
         """
         return VariantUtils.to_json(self.value, self.metadata, zone_id)
 
+    @classmethod
+    def parseJson(cls, json_str: str) -> "VariantVal":

Review Comment:
   but I am okay



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to