gene-db commented on code in PR #49450:
URL: https://github.com/apache/spark/pull/49450#discussion_r1913484164
##########
python/pyspark/sql/variant_utils.py:
##########
@@ -140,6 +157,15 @@ def to_python(cls, value: bytes, metadata: bytes) -> str:
"""
return cls._to_python(value, metadata, 0)
+ @classmethod
+ def parse_json(cls, json_str: str) -> Tuple[bytes, bytes]:
Review Comment:
The functionality is just split up into different files. `VariantVal` is
actual variant value users can get (and now create), but the implementation
lives in `VariantUtils`. I originally split it up to keep all the
implementation details separate from the `types.py`, since there are a lot of
details and bit manipulation for the variant binary format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
