liviazhu-db commented on code in PR #49451:
URL: https://github.com/apache/spark/pull/49451#discussion_r1913682666
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala:
##########
@@ -291,7 +291,8 @@ private[sql] class HDFSBackedStateStoreProvider extends
StateStoreProvider with
newMap
}
catch {
- case e: SparkException if
e.getCondition.contains("CANNOT_LOAD_STATE_STORE") =>
+ case e: SparkException
+ if Option(e.getCondition).contains("CANNOT_LOAD_STATE_STORE") =>
Review Comment:
I can't speak to any other uses of `e.getCondition` - perhaps there is some
logic that guarantees the its existence? I know that for the specific cases in
the PR, we were able to repro a NullPointerException from these calls. As for
the specific case above, I can't see anything that would prevent a NPE here,
but perhaps we can get someone with more context on this part of the code
(maybe @WweiL?) to chime in. With his input, I could add this fix to this PR
but the other 35+ uses may be more difficult to verify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
