LuciferYang commented on code in PR #49451:
URL: https://github.com/apache/spark/pull/49451#discussion_r1912021158
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala:
##########
@@ -291,7 +291,8 @@ private[sql] class HDFSBackedStateStoreProvider extends
StateStoreProvider with
newMap
}
catch {
- case e: SparkException if
e.getCondition.contains("CANNOT_LOAD_STATE_STORE") =>
+ case e: SparkException
+ if Option(e.getCondition).contains("CANNOT_LOAD_STATE_STORE") =>
Review Comment:
Good catch
https://github.com/apache/spark/blob/f0f850dc21ecf928995736daf8b790082e099221/sql/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala#L3151-L3160
Do you think there is also a risk of `NPE` in the code above? In the current
production code, `e.getCondition` is called over 35 times. Are all other
invocations free from the risk of NPE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
