changgyoopark-db commented on code in PR #49370:
URL: https://github.com/apache/spark/pull/49370#discussion_r1913342621
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/execution/ExecuteGrpcResponseSender.scala:
##########
@@ -319,7 +325,14 @@ private[connect] class ExecuteGrpcResponseSender[T <:
Message](
log"waitingForResults=${MDC(WAIT_RESULT_TIME, consumeSleep /
NANOS_PER_MILLIS.toDouble)} ms " +
log"waitingForSend=${MDC(WAIT_SEND_TIME, sendSleep /
NANOS_PER_MILLIS.toDouble)} ms")
// scalastyle:on line.size.limit
- grpcObserver.onCompleted()
+ if (executionCompleted && !sizeLimitReached) {
Review Comment:
I agree; that's not elegant. :-( I'll try to fix the issue entirely
differently, possibly not involving ExecuteGrpcResponseSender.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
