changgyoopark-db commented on code in PR #49370:
URL: https://github.com/apache/spark/pull/49370#discussion_r1913236077
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/execution/ExecuteThreadRunner.scala:
##########
@@ -63,6 +63,16 @@ private[connect] class ExecuteThreadRunner(executeHolder:
ExecuteHolder) extends
}
}
+ /**
+ * Checks if the execution is completed.
+ *
+ * @return
+ * true if the execution is completed.
+ */
+ private[connect] def isCompleted(): Boolean = {
+ state.getAcquire() == ThreadState.completed
+ }
Review Comment:
If ExecuteThreadRunner fails to start, an exception will be raised from
SparkConnectExecutePlanHandler.
(disclaimer: I'm not an JVM expert) Can there be any situation where a
thread is silently gone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
