cloud-fan commented on code in PR #49340:
URL: https://github.com/apache/spark/pull/49340#discussion_r1903539555
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AnsiTypeCoercion.scala:
##########
@@ -102,6 +104,9 @@ object AnsiTypeCoercion extends TypeCoercionBase {
case (NullType, t1) => Some(t1)
case (t1, NullType) => Some(t1)
+ case(s1: StringType, s2: StringType) if
SQLConf.get.preserveCharVarcharTypeInfo =>
Review Comment:
If we see char/varchar in the type system, it means
`preserveCharVarcharTypeInfo` is true and we don't rewrite them to StringType
at the beginning. We don't need to check the conf again here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
