mihailom-db commented on code in PR #49340:
URL: https://github.com/apache/spark/pull/49340#discussion_r1901860362
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/CharVarcharUtils.scala:
##########
@@ -161,25 +161,25 @@ object CharVarcharUtils extends Logging with
SparkCharVarcharUtils {
charFuncName: Option[String],
varcharFuncName: Option[String]): Expression = {
dt match {
- case CharType(length) if charFuncName.isDefined =>
+ case c @ CharType(length) if charFuncName.isDefined =>
StaticInvoke(
classOf[CharVarcharCodegenUtils],
if (SQLConf.get.preserveCharVarcharTypeInfo) {
- CharType(length)
+ c
} else {
- StringType
Review Comment:
This seems like an unnecessary change for now.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/CharVarcharUtils.scala:
##########
@@ -161,25 +161,25 @@ object CharVarcharUtils extends Logging with
SparkCharVarcharUtils {
charFuncName: Option[String],
varcharFuncName: Option[String]): Expression = {
dt match {
- case CharType(length) if charFuncName.isDefined =>
+ case c @ CharType(length) if charFuncName.isDefined =>
StaticInvoke(
classOf[CharVarcharCodegenUtils],
if (SQLConf.get.preserveCharVarcharTypeInfo) {
- CharType(length)
+ c
} else {
- StringType
+ StringType(c.collationId)
},
charFuncName.get,
expr :: Literal(length) :: Nil,
returnNullable = false)
- case VarcharType(length) if varcharFuncName.isDefined =>
+ case v @ VarcharType(length) if varcharFuncName.isDefined =>
StaticInvoke(
classOf[CharVarcharCodegenUtils],
if (SQLConf.get.preserveCharVarcharTypeInfo) {
- VarcharType(length)
+ v
} else {
- StringType
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
