stefankandic commented on code in PR #49114:
URL: https://github.com/apache/spark/pull/49114#discussion_r1878341479
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCoercion.scala:
##########
@@ -357,6 +357,9 @@ object CollationTypeCoercion {
case collate: Collate =>
Some(addContextToStringType(collate.dataType, Explicit))
+ case expr @ (_: NamedExpression | _: SubqueryExpression | _:
VariableReference) =>
Review Comment:
Yes, I'd like to have these sorted by collation strength, so that implicit
case comes before the cast. I didn't think about it when I added the `cast`
case...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
