MaxGekk commented on code in PR #49114:
URL: https://github.com/apache/spark/pull/49114#discussion_r1878107344
##########
sql/core/src/test/scala/org/apache/spark/sql/collation/CollationTypePrecedenceSuite.scala:
##########
@@ -110,6 +110,54 @@ class CollationTypePrecedenceSuite extends QueryTest with
SharedSparkSession {
}
}
+ test("lateral alias has implicit strength") {
+ checkAnswer(
+ sql(s"""
+ |SELECT
+ | a collate unicode as col1,
+ | COLLATION(col1 || 'b')
+ |FROM VALUES ('a') AS t(a)
+ |""".stripMargin),
+ Row("a", UNICODE_COLLATION_NAME))
+
+ assertImplicitMismatch(
+ sql(s"""
+ |SELECT
+ | a collate unicode as col1,
+ | a collate utf8_lcase as col2,
+ | col1 = col2
+ |FROM VALUES ('a') AS t(a)
+ |""".stripMargin))
+
+ checkAnswer(
+ sql(s"""
Review Comment:
```suggestion
sql("""
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCoercion.scala:
##########
@@ -357,6 +357,9 @@ object CollationTypeCoercion {
case collate: Collate =>
Some(addContextToStringType(collate.dataType, Explicit))
+ case expr @ (_: NamedExpression | _: SubqueryExpression | _:
VariableReference) =>
Review Comment:
is there any reason to move this `case` up?
##########
sql/core/src/test/scala/org/apache/spark/sql/collation/CollationTypePrecedenceSuite.scala:
##########
@@ -110,6 +110,54 @@ class CollationTypePrecedenceSuite extends QueryTest with
SharedSparkSession {
}
}
+ test("lateral alias has implicit strength") {
+ checkAnswer(
+ sql(s"""
Review Comment:
interpolation is not needed here. could you remove s":
```suggestion
sql("""
```
##########
sql/core/src/test/scala/org/apache/spark/sql/collation/CollationTypePrecedenceSuite.scala:
##########
@@ -110,6 +110,54 @@ class CollationTypePrecedenceSuite extends QueryTest with
SharedSparkSession {
}
}
+ test("lateral alias has implicit strength") {
+ checkAnswer(
+ sql(s"""
+ |SELECT
+ | a collate unicode as col1,
+ | COLLATION(col1 || 'b')
+ |FROM VALUES ('a') AS t(a)
+ |""".stripMargin),
+ Row("a", UNICODE_COLLATION_NAME))
+
+ assertImplicitMismatch(
+ sql(s"""
Review Comment:
```suggestion
sql("""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
