HyukjinKwon commented on code in PR #49118:
URL: https://github.com/apache/spark/pull/49118#discussion_r1876983091
##########
sql/core/src/test/scala/org/apache/spark/sql/VariantWriteShreddingSuite.scala:
##########
@@ -67,6 +67,34 @@ class VariantWriteShreddingSuite extends SparkFunSuite with
ExpressionEvalHelper
private val emptyMetadata: Array[Byte] = parseJson("null").getMetadata
+ test("variantShreddingSchema") {
+ // Validate the schema produced by
SparkShreddingUtils.variantShreddingSchema for a few simple
+ // cases.
+ // metadata is always non-nullable.
+ assert(SparkShreddingUtils.variantShreddingSchema(IntegerType) ==
+ StructType(Seq(StructField("metadata", BinaryType, nullable = false),
+ StructField("value", BinaryType, nullable = true),
Review Comment:
can we have double spaced indentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
