cashmand opened a new pull request, #49118:
URL: https://github.com/apache/spark/pull/49118
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
The `variantShreddingSchema` method converts a human-readable schema for
Variant to one that's a valid shredding schema. According to the shredding
schema in https://github.com/apache/parquet-format/pull/461, each shredded
field in an object should be a required group - i.e. a non-nullable struct.
This PR fixes the `variantShreddingSchema` to mark that struct as non-nullable.
### Why are the changes needed?
If we use `variantShreddingSchema` to construct a schema for Parquet, the
schema would be technically non-conformant with the spec by setting the group
as optional. I don't think this should really matter to readers, but it would
waste a bit of space in the Parquet file by adding an extra definition level.
### Does this PR introduce _any_ user-facing change?
No, this code is not used yet.
### How was this patch tested?
Added a test to do some minimal validation of the `variantShreddingSchema`
function.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
