cloud-fan commented on code in PR #48307: URL: https://github.com/apache/spark/pull/48307#discussion_r1846813525
########## python/pyspark/sql/tests/test_types.py: ########## @@ -753,6 +753,9 @@ def test_cast_to_string_with_udt(self): result = df.select(F.col("point").cast("string"), F.col("pypoint").cast("string")).head() self.assertEqual(result, Row(point="(1.0, 2.0)", pypoint="[3.0, 4.0]")) + @unittest.skipIf( + "SPARK_SKIP_CONNECT_COMPAT_TESTS" in os.environ, "SPARK-49787: Supported since Spark 4.0.0" Review Comment: wait, so PRs merged into the master branch may break tests in branch 3.5? And it's because the Spark Connect test is cross-versions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org