dongjoon-hyun commented on code in PR #48307: URL: https://github.com/apache/spark/pull/48307#discussion_r1846767035
########## python/pyspark/sql/tests/test_types.py: ########## @@ -753,6 +753,9 @@ def test_cast_to_string_with_udt(self): result = df.select(F.col("point").cast("string"), F.col("pypoint").cast("string")).head() self.assertEqual(result, Row(point="(1.0, 2.0)", pypoint="[3.0, 4.0]")) + @unittest.skipIf( + "SPARK_SKIP_CONNECT_COMPAT_TESTS" in os.environ, "SPARK-49787: Supported since Spark 4.0.0" Review Comment: To @cloud-fan , the failure happens after the following as mentioned in the PR. - #48251 AFAIK, it was not supported in `branch-3.4`. So, it fails during the compat test. Although you reverted it, you will introduce the following right? Are you going to backport it to branch-3.4? If then, we can revert this PR after merging your PR to branch-3.4. - #48881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org