cloud-fan commented on code in PR #48847:
URL: https://github.com/apache/spark/pull/48847#discussion_r1843582476
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/parameters.scala:
##########
@@ -189,7 +189,8 @@ object BindParameters extends ParameterizedQueryProcessor
with QueryErrorsBase {
// We should wait for `CTESubstitution` to resolve CTE before binding
parameters, as CTE
// relations are not children of `UnresolvedWith`.
Review Comment:
I'm thinking of a different approach: shall we explicitly match
`UnresolvedWith` here and bind parameters in the CTE relations? Then we no
longer need this hack to delay parameter binding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
