cloud-fan commented on code in PR #48847:
URL: https://github.com/apache/spark/pull/48847#discussion_r1843518188


##########
sql/core/src/test/scala/org/apache/spark/sql/ParametersSuite.scala:
##########
@@ -741,4 +741,21 @@ class ParametersSuite extends QueryTest with 
SharedSparkSession with PlanTest {
         Row("c1"))
     }
   }
+
+  test("SPARK-50322: parameterized identifier in a sub-query") {
+    withTable("tt1") {
+      sql("create table tt1(c1 int)")
+      sql("insert into tt1 values (1)")
+      def query(p: String): String = {
+        s"""
+          |with v1 as (
+          |  select * from tt1
+          |  where 1 = (Select * from identifier($p))

Review Comment:
   or we should upper case all SQL keywords



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to