amaliujia commented on code in PR #47592:
URL: https://github.com/apache/spark/pull/47592#discussion_r1704878465
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogManager.scala:
##########
@@ -106,19 +106,25 @@ class CatalogManager(
}
}
- def setCurrentNamespace(namespace: Array[String]): Unit = synchronized {
+ private def assertNamespaceExist(namespace: Array[String]): Unit = {
currentCatalog match {
- case _ if isSessionCatalog(currentCatalog) && namespace.length == 1 =>
- v1SessionCatalog.setCurrentDatabase(namespace.head)
- case _ if isSessionCatalog(currentCatalog) =>
- throw QueryCompilationErrors.noSuchNamespaceError(namespace)
case catalog: SupportsNamespaces if !catalog.namespaceExists(namespace)
=>
- throw QueryCompilationErrors.noSuchNamespaceError(namespace)
+ throw QueryCompilationErrors.noSuchNamespaceError(catalog.name() +:
namespace)
case _ =>
- _currentNamespace = Some(namespace)
}
}
+ def setCurrentNamespace(namespace: Array[String]): Unit = synchronized {
+ if (isSessionCatalog(currentCatalog) && namespace.length == 1) {
+ v1SessionCatalog.validateGlobalTempView(namespace.head)
+ assertNamespaceExist(namespace)
+ v1SessionCatalog.setCurrentDatabaseWithoutCheck(namespace.head)
Review Comment:
Good point. I do not need to check this in the `withoutCheck` version as
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
