amaliujia commented on code in PR #47592:
URL: https://github.com/apache/spark/pull/47592#discussion_r1704861748
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala:
##########
@@ -343,6 +351,15 @@ class SessionCatalog(
synchronized { currentDb = dbName }
}
+ def setCurrentDatabaseWithoutCheck(db: String): Unit = {
Review Comment:
Yes. This is because `setCurrentDatabase` has a db exists check, and we have
already checked before setting the current db state. And if we still do the db
exists check, it will fail custom catalog (e.g. custom session catalog) case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
