dongjoon-hyun commented on code in PR #27:
URL: 
https://github.com/apache/spark-kubernetes-operator/pull/27#discussion_r1694480849


##########
config/pmd/ruleset.xml:
##########
@@ -21,13 +21,12 @@
   <description>
     Spark Operator Ruleset
   </description>
-  <rule ref="category/java/bestpractices.xml"/>
+  <rule ref="category/java/bestpractices.xml">
+    <exclude name="JUnitAssertionsShouldIncludeMessage" />

Review Comment:
   This is recommended, but we have many assertions already. We don't need to 
enforce it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to