dongjoon-hyun commented on code in PR #27:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/27#discussion_r1694480262
##########
config/pmd/ruleset.xml:
##########
@@ -21,13 +21,12 @@
<description>
Spark Operator Ruleset
</description>
- <rule ref="category/java/bestpractices.xml"/>
+ <rule ref="category/java/bestpractices.xml">
+ <exclude name="JUnitAssertionsShouldIncludeMessage" />
+ <exclude name="JUnitTestContainsTooManyAsserts" />
+ </rule>
<rule ref="category/java/security.xml"/>
<rule ref="rulesets/java/basic.xml"/>
- <rule ref="category/java/bestpractices.xml/JUnitTestContainsTooManyAsserts">
- <properties>
- <property name="maximumAsserts" value="10"/>
Review Comment:
This was already broken. So, I removed this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
