uros-db commented on code in PR #46003: URL: https://github.com/apache/spark/pull/46003#discussion_r1568660077
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ########## @@ -1698,10 +1703,10 @@ case class FormatString(children: Expression*) extends Expression with ImplicitC override def foldable: Boolean = children.forall(_.foldable) override def nullable: Boolean = children(0).nullable - override def dataType: DataType = StringType + override def dataType: DataType = SQLConf.get.defaultStringType Review Comment: +1 for the children(0).dataType, without casting approach -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
