uros-db commented on code in PR #46003:
URL: https://github.com/apache/spark/pull/46003#discussion_r1568662503
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##########
@@ -2320,9 +2328,9 @@ case class Levenshtein(
case class SoundEx(child: Expression)
extends UnaryExpression with ExpectsInputTypes with NullIntolerant {
- override def dataType: DataType = StringType
+ override def dataType: DataType = SQLConf.get.defaultStringType
Review Comment:
+1 for Nikola's reasoning
I would go with `SQLConf.get.defaultStringType` here, based on how this
expression works, it seems to me that SoundEx result type doesn't really have
anything to do with input type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
