Github user mccheah commented on the pull request:

    https://github.com/apache/spark/pull/4972#issuecomment-78716036
  
    Hm, yeah I'm not too opinionated about saving the tiniest of fractions of 
seconds by avoiding calling instanceOf too many times - instanceOf is really 
really cheap compared to java.lang.reflect.Array as it is. If the majority 
opinion is that I made it too complex we can move to just using Scala's Arrays 
methods.
    
    (I don't have that much time to work on this any more until after the 
weekend though.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to