----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75167/ -----------------------------------------------------------
(Updated Aug. 14, 2024, 11:15 p.m.) Review request for mesos and Benjamin Mahler. Summary (updated) ----------------- [cgroups2] Add isolate field for nested containers. Repository: mesos Description (updated) ------- Currently we do not support nested containers. We need to let nested containers pick whether they want their own resource constraints based on the LinuxInfo::share_cgroups field in the API. In cgroups v1, we didn't need to track an additional field for this, because the isolator does not store nested containers within its `infos` map. In cgroups v2, we will *always* create cgroups for nested containers, and LinuxInfo::share_cgroups instead specifies whether these cgroups will have resource isolation applied to them. (LinuxInfo::share_cgroups needs to be renamed accordingly). In later patches, we will use this to skip the update and isolate calls on the controllers if isolate == false. Diffs (updated) ----- src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.hpp 07eb036818ba86c4171658cc40956b66ce5db8a5 src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp 762bb112203cdeac09d47c2350b7b767c9dc8340 Diff: https://reviews.apache.org/r/75167/diff/2/ Changes: https://reviews.apache.org/r/75167/diff/1-2/ Testing ------- Compiles okay Thanks, Jason Zhou
