----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75167/#review226840 -----------------------------------------------------------
It seems off that the v1 isolator doesn't have this bool but the v2 isolator does? FYI, the way that containers specify this from the api is here: https://github.com/apache/mesos/blob/7918b06c11302f6c614ade51d4b327580588ac71/include/mesos/v1/mesos.proto#L3552-L3565 Devin and I had discussed this during his work, not sure if he captured that discussion in the notes he sent to you, but I seem to recall discussing how this field should be more about whether to isolate resources / namespaces than to share cgroups (which doesn't necessarily entail resource isolation), although I can't recall the details of what we discussed at this point. - Benjamin Mahler On Aug. 14, 2024, 12:09 a.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75167/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2024, 12:09 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently we do not support nested containers. We need to let nested > containers pick whether they want their own resource constraints. > > We will do give the ability to choose with an 'isolate' field. > If this field is set to false, it indicates the container does not > want its own resource constraints, and does not want cgroups2 isolator > to update its control files. In later patches, we will use this to skip > the update and isolate calls on the controllers if isolate == true. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.hpp > 07eb036818ba86c4171658cc40956b66ce5db8a5 > src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp > 762bb112203cdeac09d47c2350b7b767c9dc8340 > > > Diff: https://reviews.apache.org/r/75167/diff/1/ > > > Testing > ------- > > Compiles okay > > > Thanks, > > Jason Zhou > >
