----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75158/ -----------------------------------------------------------
(Updated Aug. 9, 2024, 7:29 p.m.) Review request for mesos and Benjamin Mahler. Summary (updated) ----------------- [cgroups2] Collect process & thread from leaf groups Repository: mesos Description ------- Currently, our core controller usage() function try to read the cgroup files in the argument cgroup. However, in our design for cgroups v2, processes and threads live in the leaf child of a cgroup. Hence the usage collection will not find the actual processes and threads for a cgroup if it's not already specified as a leaf group. This patch adds a check to see if the argument cgroup is a leaf cgroup, and will search for processes and threads in the leaf cgroup instead. Diffs (updated) ----- src/slave/containerizer/mesos/isolators/cgroups2/controllers/core.cpp 54d7c89777f3a360e641692fd7d2184bbac74103 Diff: https://reviews.apache.org/r/75158/diff/3/ Changes: https://reviews.apache.org/r/75158/diff/2-3/ Testing ------- CgroupsIsolatorTest.ROOT_CGROUPS_PidsAndTids is able to correctly find the number of processes/threads after this and the subsequent patches are applied Thanks, Jason Zhou
