----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75158/#review226801 -----------------------------------------------------------
This library shouldn't know about the leaf cgroup convention specific to mesos' containerization, so this should go up into the call site that's problematic. - Benjamin Mahler On Aug. 9, 2024, 3:45 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75158/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2024, 3:45 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently, our threads and processes functions try to read the cgroup > files in the argument cgroup. However, in our design for cgroups v2, > processes and threads live in the leaf child of a cgroup. Hence the > usage collection will not find the actual processes and threads for a > cgroup if it's not already specified as a leaf group. > > This patch adds a check to see if the argument cgroup is a leaf cgroup, > and will search for processes and threads in the leaf cgroup instead. > > > Diffs > ----- > > src/linux/cgroups2.cpp 9dd100aa6d224d67166cc80473423ea5fa815c14 > > > Diff: https://reviews.apache.org/r/75158/diff/1/ > > > Testing > ------- > > CgroupsIsolatorTest.ROOT_CGROUPS_PidsAndTids is able to correctly find the > number of processes/threads after this and the subsequent patches are applied > > > Thanks, > > Jason Zhou > >
