----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75074/ -----------------------------------------------------------
(Updated Aug. 1, 2024, 7:42 p.m.) Review request for mesos and Benjamin Mahler. Changes ------- Remove new GPU isolator, original isolator now uses DeviceManager if cgroups2 is mounted Summary (updated) ----------------- [cgroups2] Support DeviceManager in GPU isolator Repository: mesos Description (updated) ------- Currently, the GPU isolator assumes we are only using cgroups v1, and makes use of the cgroups::devices::allow and deny functions to control GPU access. In Cgroups2, we need to attach ebpf programs for the specific cgroups, which is done for us in the DeviceManager. Hence, we need to use the DeviceManager in the GPU isolator depending on whether cgroups v1 or v2 is currently mounted Diffs (updated) ----- src/slave/containerizer/mesos/containerizer.cpp 9bafb137ba67bfed5cfb24c1a3af9203fde9e821 src/slave/containerizer/mesos/isolators/gpu/isolator.hpp e4f221d5f63ed1db044acabbbd427a30a0f69ced src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 99119f938e2eb5ca6a8b64d073c87ca5032a00b8 Diff: https://reviews.apache.org/r/75074/diff/3/ Changes: https://reviews.apache.org/r/75074/diff/2-3/ Testing (updated) ------- Existing GPU isolator tests pass, with the exception of the DefaultExecutorVerifyDeviceAccess test which is because we currently don't support nested containers. Thanks, Jason Zhou
