----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75074/#review226754 -----------------------------------------------------------
rather than copy the entire isolator, is it possible to use if conditions around the device allow/deny behavior? - Benjamin Mahler On July 31, 2024, 7:29 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75074/ > ----------------------------------------------------------- > > (Updated July 31, 2024, 7:29 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Currently, we only have access to one GPU isolator that makes use of > cgroups v1. We need to create a new GPU isolator that does not rely on > hierarchies so that it is compatible with cgroups v2. > > The GPU isolator should preserve all of its previous functionalities > and make use of the DeviceManager to help it allocate and deallocate > GPU devices. > > > Diffs > ----- > > src/CMakeLists.txt 9526ed17a1ccb88941fdfa3cea923c9260f68c43 > src/Makefile.am 456942389b4770ab1109ab5cdf370b004b1b9462 > src/slave/containerizer/mesos/isolators/gpu/cgroups2_gpu_isolator.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/gpu/cgroups2_gpu_isolator.cpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/gpu/nvidia.hpp > 85cfa681d58699fcb4aa20501c9151f7554d3377 > > > Diff: https://reviews.apache.org/r/75074/diff/2/ > > > Testing > ------- > > Compiles okay, existing GPU isolator tests pass when #75131 is applied, with > the exception of the DefaultExecutorVerifyDeviceAccess test which is because > we currently don't support nested containers. > > > Thanks, > > Jason Zhou > >
