cf-natali commented on a change in pull request #409:
URL: https://github.com/apache/mesos/pull/409#discussion_r716039396
##########
File path: src/python/cli_new/lib/cli/tests/base.py
##########
@@ -272,41 +274,33 @@ def launch(self, timeout=TIMEOUT):
super(Agent, self).launch()
Agent.count += 1
- try:
- # pylint: disable=missing-docstring
- def single_slave(data):
- return len(data["slaves"]) == 1
-
- http.get_json(self.flags["master"], "slaves", single_slave,
timeout)
- except Exception as exception:
+ data = http.get_json(self.flags["master"], "slaves", self.config)
+ if len(data["slaves"]) == 1:
Review comment:
I don't understand this change - it looks like before, the test only
worked with a single slave.
Now, it looks like it will throw if there is a single slave?
```
if len(data["slaves"]) == 1:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
