andreaspeters commented on a change in pull request #409:
URL: https://github.com/apache/mesos/pull/409#discussion_r713729146
##########
File path: src/python/cli_new/lib/cli/http.py
##########
@@ -64,13 +64,11 @@ def read_endpoint(addr, endpoint, config, query=None):
.format(url=url, error=str(exception)))
-def get_json(addr, endpoint, config, condition=None, query=None):
+def get_json(addr, endpoint, config, query=None):
Review comment:
ok, after cleanup, the test fails also on my site.
But the problem is not timeout, it's the removed condition variable. I can
re-implement it. But it's only used for the test. :man_shrugging: What do u
think? Shell I let it inside or remove it and change the test functions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]