> On Aug. 20, 2020, 2:41 p.m., Qian Zhang wrote: > > src/slave/csi_server.cpp > > Lines 280-282 (patched) > > <https://reviews.apache.org/r/72779/diff/3/?file=2238503#file2238503line284> > > > > I think we should log an error message here, otherwise when > > `initializePlugin()` is called in `start()` we will not know which plugin > > is failed to initialize.
And it seems we do not have a log message to state that a plugin has been successfully initialized which I think would be helpful for debuggability. So maybe we should change this `repair()` method to `onAny()` where we can log an INFO message for the successful plugin initialization and still do `plugins.erase(name)` on any failures, WDYT? - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72779/#review221655 ----------------------------------------------------------- On Aug. 20, 2020, 3:04 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72779/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2020, 3:04 a.m.) > > > Review request for mesos and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Initialized plugins lazily in the CSI server. > > > Diffs > ----- > > src/slave/csi_server.hpp f5ec7663926731483589c5e30e7060751ed01e55 > src/slave/csi_server.cpp 2ba4f22b92370b019722d845d6113fb37f1b876a > > > Diff: https://reviews.apache.org/r/72779/diff/3/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh --gtest_filter="*CSIServerTest*"` > > > Thanks, > > Greg Mann > >
