----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72779/#review221653 -----------------------------------------------------------
src/slave/csi_server.cpp Lines 186 (patched) <https://reviews.apache.org/r/72779/#comment310720> I'd suggest to add `path` in this error message so we could know which plugin config file has a problem. Ditto for the `Protobuf parse failed ...` error message below. src/slave/csi_server.cpp Lines 280 (patched) <https://reviews.apache.org/r/72779/#comment310721> So here we erase the plugin while `plugin.initialized` is already associated at line 249 and `CSIServerProcess::publishVolume()` or `CSIServerProcess::unpublishVolume` may already be waiting on `plugins.at(name).initialized.future()`, will the erasing cause any problems? src/slave/csi_server.cpp Lines 308 (patched) <https://reviews.apache.org/r/72779/#comment310719> Kill this newline. Ditto for the similar code in `CSIServerProcess::publishVolume` and `CSIServerProcess::unpublishVolume` - Qian Zhang On Aug. 20, 2020, 3:04 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72779/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2020, 3:04 a.m.) > > > Review request for mesos and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Initialized plugins lazily in the CSI server. > > > Diffs > ----- > > src/slave/csi_server.hpp f5ec7663926731483589c5e30e7060751ed01e55 > src/slave/csi_server.cpp 2ba4f22b92370b019722d845d6113fb37f1b876a > > > Diff: https://reviews.apache.org/r/72779/diff/3/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh --gtest_filter="*CSIServerTest*"` > > > Thanks, > > Greg Mann > >
