> On Aug. 17, 2020, 3:13 a.m., Qian Zhang wrote: > > src/slave/csi_server.cpp > > Lines 204 (patched) > > <https://reviews.apache.org/r/72779/diff/1/?file=2238169#file2238169line235> > > > > Will this `repair` get invoked when each of the above `then()` fails? > > Or it will get invoked only when the last `then()` fails?
Yes, `repair()` will be invoked here if a failure occurs at any stage because `then()` propagates failures forward in the chain: https://github.com/apache/mesos/blob/b1b3ed096e31260a25ba74927786db3f92afb9d3/3rdparty/libprocess/include/process/future.hpp#L1478-L1479 - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72779/#review221596 ----------------------------------------------------------- On Aug. 19, 2020, 6:23 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72779/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2020, 6:23 a.m.) > > > Review request for mesos and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > This patch updates the CSI server to attempt to > initialize unknown plugins when it receives publish > or unpublish calls meant for plugins that it does > not recognize. > > > Diffs > ----- > > src/slave/csi_server.hpp f5ec7663926731483589c5e30e7060751ed01e55 > src/slave/csi_server.cpp 2ba4f22b92370b019722d845d6113fb37f1b876a > > > Diff: https://reviews.apache.org/r/72779/diff/2/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh --gtest_filter="*CSIServerTest*"` > > > Thanks, > > Greg Mann > >
