----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72779/#review221596 -----------------------------------------------------------
src/slave/csi_server.cpp Lines 119 (patched) <https://reviews.apache.org/r/72779/#comment310660> s/future/promise/ src/slave/csi_server.cpp Lines 171-172 (original), 148-152 (patched) <https://reviews.apache.org/r/72779/#comment310661> Can we change the constructor of `CSIPlugin` by passing `info` into it as well? Then we do not have to assign `info` at line 152. src/slave/csi_server.cpp Lines 204 (patched) <https://reviews.apache.org/r/72779/#comment310662> Will this `repair` get invoked when each of the above `then()` fails? Or it will get invoked only when the last `then()` fails? - Qian Zhang On Aug. 15, 2020, 11:54 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72779/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2020, 11:54 p.m.) > > > Review request for mesos and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > This patch updates the CSI server to lazily initialize CSI > plugins on-demand when the server receives publish or > unpublish calls for a plugin which is not already > successfully initialized. > > > Diffs > ----- > > src/slave/csi_server.cpp a9a399579c6f7683b36e72582da20ea39311a222 > > > Diff: https://reviews.apache.org/r/72779/diff/1/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh --gtest_filter="*CSIServerTest*"` > > > Thanks, > > Greg Mann > >
