> On Jan. 18, 2018, 6:49 p.m., Greg Mann wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 1749 (patched) > > <https://reviews.apache.org/r/65032/diff/2/?file=1938028#file1938028line1749> > > > > I'm curious why you place all expectations together in some tests, and > > spread them throughout the test here and elsewhere? > > Chun-Hung Hsiao wrote: > It's just the first one or two where I set all expectations together, > then in the succeeding tests I feel the logic might be easier to > follow/modify if they're set as the test progresses. Also in some tests I > want to wait for the resources obtained in previous offers. I still keep the > declarations and comments together as they provide a detailed description of > the scenario we're testing. I could use a follow-up patch to rewrite the > first few tests to make it consistent.
Addressed in the next patch in the chain. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65032/#review195643 ----------------------------------------------------------- On Jan. 10, 2018, 2:36 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65032/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2018, 2:36 a.m.) > > > Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu. > > > Bugs: MESOS-8415 > https://issues.apache.org/jira/browse/MESOS-8415 > > > Repository: mesos > > > Description > ------- > > Added a SLRP unit test for agent reboot. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > bbfe95e9818f25fdd5405db3ad2fe355e023f743 > > > Diff: https://reviews.apache.org/r/65032/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
