----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65032/#review195643 -----------------------------------------------------------
src/tests/storage_local_resource_provider_tests.cpp Lines 1697 (patched) <https://reviews.apache.org/r/65032/#comment275029> s/agentFlags/slaveFlags/g Or, let's just follow up at the end of the chain with a patch. I'm fine either way. src/tests/storage_local_resource_provider_tests.cpp Lines 1703-1711 (patched) <https://reviews.apache.org/r/65032/#comment274908> Ditto here as in parent review - I think we can make this more concise? src/tests/storage_local_resource_provider_tests.cpp Lines 1749 (patched) <https://reviews.apache.org/r/65032/#comment274915> I'm curious why you place all expectations together in some tests, and spread them throughout the test here and elsewhere? src/tests/storage_local_resource_provider_tests.cpp Lines 1753 (patched) <https://reviews.apache.org/r/65032/#comment275031> s/agent/slave/ src/tests/storage_local_resource_provider_tests.cpp Lines 1759 (patched) <https://reviews.apache.org/r/65032/#comment274916> s/volume/volumes/ src/tests/storage_local_resource_provider_tests.cpp Lines 1780-1781 (patched) <https://reviews.apache.org/r/65032/#comment275026> Do we need the `.Times(Atleast(1))` here? I think we can rely on a single offer being rescinded when the agent is terminated? src/tests/storage_local_resource_provider_tests.cpp Lines 1867 (patched) <https://reviews.apache.org/r/65032/#comment275028> Could we move the registering of this expectation out of this scope, and directly above the `StartSlave()` call below? - Greg Mann On Jan. 10, 2018, 2:36 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65032/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2018, 2:36 a.m.) > > > Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu. > > > Bugs: MESOS-8415 > https://issues.apache.org/jira/browse/MESOS-8415 > > > Repository: mesos > > > Description > ------- > > Added a SLRP unit test for agent reboot. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > bbfe95e9818f25fdd5405db3ad2fe355e023f743 > > > Diff: https://reviews.apache.org/r/65032/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
