----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64743/#review194705 -----------------------------------------------------------
Ship it! I can't vouch for the compiler flags themselves, but the CMake part looks good and appears consistent with the Autotools changes; moreover, it passed on the Windows ReviewBot, so it _is_ correctly not adding the flags if the check for their support failed. - Andrew Schwartzmeyer On Dec. 20, 2017, 5:47 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64743/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2017, 5:47 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. > > > Bugs: MESOS-8348 > https://issues.apache.org/jira/browse/MESOS-8348 > > > Repository: mesos > > > Description > ------- > > If we tell the compiler to place each function in a separate > section, this allows the linker to garbage collect unused > sections. This significantly decreases the size of the final > build artifacts and provides some modest improvements in build > times. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake dc9dc161dce1c714748bcec2fc15c4fbfbccaec2 > configure.ac 5ffc33a6b9495db64f1ec164ed96f3faea620348 > > > Diff: https://reviews.apache.org/r/64743/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > James Peach > >
