> On Dec. 20, 2017, 10:52 a.m., Benjamin Bannier wrote: > > cmake/CompilationConfigure.cmake > > Lines 267 (patched) > > <https://reviews.apache.org/r/64743/diff/1/?file=1924221#file1924221line267> > > > > What about static archives? Last time I looked this was broken in the > > cmake setup, but it would be great to prepare to also make use of this flag > > there once its ready (if applicable).
GC sections can't really apply to archives since you don't know which sections it is safe to GC. > On Dec. 20, 2017, 10:52 a.m., Benjamin Bannier wrote: > > configure.ac > > Lines 507-508 (patched) > > <https://reviews.apache.org/r/64743/diff/1/?file=1924222#file1924222line507> > > > > Why are we disabling this on macos? These flags do work with the latest > > LLVM toolchain (clang & lld), so let's default-enable it on macos as well. > > > > If you worry about some Apple clang fork not supporting these flags, > > let's please add some feature detection instead of branching on the > > platform here. Switched to just enabling it wherever it works. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64743/#review194224 ----------------------------------------------------------- On Dec. 21, 2017, 1:47 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64743/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2017, 1:47 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. > > > Bugs: MESOS-8348 > https://issues.apache.org/jira/browse/MESOS-8348 > > > Repository: mesos > > > Description > ------- > > If we tell the compiler to place each function in a separate > section, this allows the linker to garbage collect unused > sections. This significantly decreases the size of the final > build artifacts and provides some modest improvements in build > times. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake dc9dc161dce1c714748bcec2fc15c4fbfbccaec2 > configure.ac 5ffc33a6b9495db64f1ec164ed96f3faea620348 > > > Diff: https://reviews.apache.org/r/64743/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > James Peach > >
