----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62899/#review188225 -----------------------------------------------------------
Ship it! Looks good! I made some tweaks to the code and added some comments to show the tree structure. - Benjamin Mahler On Oct. 13, 2017, 12:55 p.m., Dmitry Zhuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62899/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2017, 12:55 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-6971 > https://issues.apache.org/jira/browse/MESOS-6971 > > > Repository: mesos > > > Description > ------- > > This measures performance of delivering protobuf message from receiving > `MessageEvent` till calling handler. Used to evaluate performance gains > from using protobuf arenas. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 6b2fdff375514da1285cc614c3504c4d0892e464 > 3rdparty/libprocess/src/tests/benchmarks.cpp > 8195193fbcc1c22b72cd95b09ad17f7529d1952d > 3rdparty/libprocess/src/tests/benchmarks.proto PRE-CREATION > > > Diff: https://reviews.apache.org/r/62899/diff/3/ > > > Testing > ------- > > make check > ./benchmarks > --gtest_filter=ProcessTest.Process_BENCHMARK_ProtobufInstallHandler > [ RUN ] ProcessTest.Process_BENCHMARK_ProtobufInstallHandler > Size: 4, throughput: 633872.07 messages/s > Size: 10, throughput: 403461.32 messages/s > Size: 34, throughput: 216181.66 messages/s > Size: 64, throughput: 132159.29 messages/s > Size: 154, throughput: 64097.07 messages/s > Size: 304, throughput: 34928.53 messages/s > Size: 605, throughput: 18249.50 messages/s > Size: 1507, throughput: 7521.48 messages/s > Size: 3011, throughput: 3765.40 messages/s > Size: 4515, throughput: 2526.66 messages/s > Size: 6019, throughput: 1889.99 messages/s > Size: 9027, throughput: 1192.44 messages/s > Size: 12034, throughput: 887.66 messages/s > Size: 15042, throughput: 713.76 messages/s > Size: 30081, throughput: 349.73 messages/s > [ OK ] ProcessTest.Process_BENCHMARK_ProtobufInstallHandler (15937 ms) > > > Thanks, > > Dmitry Zhuk > >
