----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62899/#review187855 -----------------------------------------------------------
3rdparty/libprocess/src/tests/benchmarks.cpp Lines 583 (patched) <https://reviews.apache.org/r/62899/#comment264889> How about `ProtobufInstallHandlerBenchmarkProcess`? 3rdparty/libprocess/src/tests/benchmarks.cpp Lines 592-596 (patched) <https://reviews.apache.org/r/62899/#comment264922> Maybe a TODO for also benchmarking the version that takes individual fields, especially because of the copying induced by the RepeatedPtrField -> vector conversion. 3rdparty/libprocess/src/tests/benchmarks.cpp Lines 598-621 (patched) <https://reviews.apache.org/r/62899/#comment264926> It would be nice to have a time-based benchmark instead of iteration based (e.g. see how many operations can be done in 1 second). That way, we have a better handle on how long the benchmarks take. As it stands, the existing benchmarks take so long that it's impossible to run them in CI or run them all locally. 3rdparty/libprocess/src/tests/benchmarks.cpp Lines 624-644 (patched) <https://reviews.apache.org/r/62899/#comment264925> Can you describe the structure of the messages being benchmarked? I'm still a little puzzled at what the overall message tree looks like here given the queue logic. :S Maybe let's pass the parameters? E.g. repeated_count, tree_depth? 3rdparty/libprocess/src/tests/benchmarks.cpp Lines 648 (patched) <https://reviews.apache.org/r/62899/#comment264890> How about `Process_BENCHMARK_ProtobufInstallHandler`? - Benjamin Mahler On Oct. 12, 2017, 1:09 p.m., Dmitry Zhuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62899/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2017, 1:09 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-6971 > https://issues.apache.org/jira/browse/MESOS-6971 > > > Repository: mesos > > > Description > ------- > > This measures performance of delivering protobuf message from receiving > `MessageEvent` till calling handler. Used to evaluate performance gains > from using protobuf arenas. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 6b2fdff375514da1285cc614c3504c4d0892e464 > 3rdparty/libprocess/src/tests/benchmarks.cpp > 8195193fbcc1c22b72cd95b09ad17f7529d1952d > 3rdparty/libprocess/src/tests/benchmarks.proto PRE-CREATION > > > Diff: https://reviews.apache.org/r/62899/diff/2/ > > > Testing > ------- > > make check > ./benchmarks --gtest_filter=ProcessTest.Process_BENCHMARK_MessagePassing > > > Thanks, > > Dmitry Zhuk > >
