----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53238/#review155024 -----------------------------------------------------------
src/slave/slave.cpp (lines 1373 - 1375) <https://reviews.apache.org/r/53238/#comment224852> we don't do this anywhere else, can we just do? ``` foreach(const SlaveID& slaveId, retiredSlaveIds) { message.add_retired_slave_ids()->CopyFrom(slaveId); } ``` src/slave/state.cpp (line 58) <https://reviews.apache.org/r/53238/#comment224854> s/findAllSlaveIDs/recoverSlaveIDs/ - Vinod Kone On Oct. 27, 2016, 6:40 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53238/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2016, 6:40 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5396 > https://issues.apache.org/jira/browse/MESOS-5396 > > > Repository: mesos > > > Description > ------- > > If the agent observes that the boot ID has changed since the last time > it successfully (re-)registered with the master, we know that any agent > IDs that were previously in use in this `work_dir` must be associated > with different boot IDs; hence, any executors/tasks associated with > those agent IDs are no longer running, and those agent ID will never > attempt to re-register with the master. The agent now reports these > retired agent IDs to the master; the master will later take advantage of > this information, e.g., to learn that an agent that we think might > re-register after master failover will never re-register. > > > Diffs > ----- > > src/messages/messages.proto 7cbac56099689ffc378d83bae3a16abb49b50dd9 > src/slave/slave.hpp c0a17657e684e87d555731d2e35ac15894c3c05b > src/slave/slave.cpp 881c10ac61d1e4fdeabdc42c0a41508c36f49040 > src/slave/state.hpp a1c849690a5c2b3fc5ea3eb2e782e99a2b0f8044 > src/slave/state.cpp a94bb8d7029295abef70d6595ebc732ac1ab87a8 > > Diff: https://reviews.apache.org/r/53238/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
